Add typing for Repository, Tool, and the managers.

Review Request #14032 — Created July 12, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

Repository is one of the main models used in Review Board, and until
now, we lacked any typing for the functions.

This change adds typing for Repository, RepositoryManager, Tool,
and ToolManager. It should ensure we don't pass incorrect parameters
to anything in these classes.

Unit tests pass.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2

Commits

First Last Summary ID Author
Add typing for Repository, Tool, and the managers.
`Repository` is one of the main models used in Review Board, and until now, we lacked any typing for the functions. This change adds typing for `Repository`, `RepositoryManager`, `Tool`, and `ToolManager`. It should ensure we don't pass incorrect parameters to anything in these classes.
6c8582f8e5d033426fefa2ba105bfc3f7daed3ea Christian Hammond
reviewboard/scmtools/managers.py
reviewboard/scmtools/models.py
Loading...