Make a few small improvements to configForms JS and CSS.

 






 

 


  Review Request #14023
  —
  Created July 11, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Djblets
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
This change makes a few small improvements to our configForms frontend

code:


    

  • The default styling for <label> elements has been updated to exclude
    
<label class="ink-c-button__label">
    • 

  • Updated definitions for onRender() and onInitialRender() to be
    
  protected. This is more correct, and fixes warnings in code which
    
  inherits from these.
    • 

  • Use modelEvents in the ListItemView instead of manually calling
    
listenTo for everything.
    • 


 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Used this with other code.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Make a few small improvements to configForms JS and CSS.
     
This change makes a few small improvements to our configForms frontend
code:

- The default styling for `<label>` elements has been updated to exclude
  `<label class="ink-c-button__label">`
- Updated definitions for `onRender()` and `onInitialRender()` to be
  protected. This is more correct, and fixes warnings in code which
  inherits from these.
- Use `modelEvents` in the ListItemView instead of manually calling
  `listenTo` for everything.

Testing Done:
- Ran js-tests.
- Used this with other code.

    

   
  		
  b25f74f9c20c1b6de6ce676a3a726282ec7e7a16
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/static/djblets/css/config-forms.less
     
    

   
  

 



 

  

   
    

     
      
      djblets/static/djblets/js/configForms/views/listItemView.ts
     
    

   
  

 



 

  

   
    

     
      
      djblets/static/djblets/js/configForms/views/listView.ts
     
    

   
  

 



 

  

   
    

     
      
      djblets/static/djblets/js/configForms/views/pagesView.ts
     
    

   
  

 



 

  

   
    

     
      
      djblets/static/djblets/js/configForms/views/tableView.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...