• 
      

    Make a few small improvements to configForms JS and CSS.

    Review Request #14023 — Created July 11, 2024 and submitted

    Information

    Djblets
    release-5.x

    Reviewers

    This change makes a few small improvements to our configForms frontend
    code:

    • The default styling for <label> elements has been updated to exclude
      <label class="ink-c-button__label">
    • Updated definitions for onRender() and onInitialRender() to be
      protected. This is more correct, and fixes warnings in code which
      inherits from these.
    • Use modelEvents in the ListItemView instead of manually calling
      listenTo for everything.
    • Ran js-tests.
    • Used this with other code.
    Summary ID
    Make a few small improvements to configForms JS and CSS.
    This change makes a few small improvements to our configForms frontend code: - The default styling for `<label>` elements has been updated to exclude `<label class="ink-c-button__label">` - Updated definitions for `onRender()` and `onInitialRender()` to be protected. This is more correct, and fixes warnings in code which inherits from these. - Use `modelEvents` in the ListItemView instead of manually calling `listenTo` for everything. Testing Done: - Ran js-tests. - Used this with other code.
    b25f74f9c20c1b6de6ce676a3a726282ec7e7a16
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-5.x (a0ed5d8)