Summary

Fix next/prev file attachments when Review UIs are unavailable.

Review Request #14022 — Created July 11, 2024 and submitted Aug. 6, 2024, 4:50 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Testing Done

Created a series of attachments where some file types just didn't have
review UIs, and some had disabled review UIs (a PDF with a user who did
not have access to power pack). Saw that I no longer got links to 404s.

Commits

Summary	ID
Fix next/prev file attachments when Review UIs are unavailable. The next and previous file attachment pop-outs were broken if an attachment either did not have a Review UI, or had a Review UI which was not available. This change makes it so we check to ensure that the link will lead to a working page, and skip over any attachments that won't. Testing Done: Created a series of attachments where some file types just didn't have review UIs, and some had disabled review UIs (a PDF with a user who did not have access to power pack). Saw that I no longer got links to 404s.	37b4a5ebc0c7d86496c1a25b962c63b24afcdf83

Summary

Fix next/prev file attachments when Review UIs are unavailable.

The next and previous file attachment pop-outs were broken if an attachment either did not have a Review UI, or had a Review UI which was not available. This change makes it so we check to ensure that the link will lead to a working page, and skip over any attachments that won't. Testing Done: Created a series of attachments where some file types just didn't have review UIs, and some had disabled review UIs (a PDF with a user who did not have access to power pack). Saw that I no longer got links to 404s.

37b4a5ebc0c7d86496c1a25b962c63b24afcdf83

Issues

Description	From	Last Updated
Can we make these keyword-only arguments?	chipx86	July 15, 2024, 9:49 p.m.
Missing a Returns and Version Added.	chipx86	July 15, 2024, 9:49 p.m.
Let's do one per line.	chipx86	July 15, 2024, 9:50 p.m.

flake8 passed.

JSHint passed.

reviewboard/reviews/ui/base.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we make these keyword-only arguments?

reviewboard/reviews/ui/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing a Returns and Version Added.
```
reviewboard/reviews/views/attachments.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's do one per line.
```

Commits:

	Summary	ID
	Fix next/prev file attachments when Review UIs are unavailable. The next and previous file attachment pop-outs were broken if an attachment either did not have a Review UI, or had a Review UI which was not available. This change makes it so we check to ensure that the link will lead to a working page, and skip over any attachments that won't. Testing Done: Created a series of attachments where some file types just didn't have review UIs, and some had disabled review UIs (a PDF with a user who did not have access to power pack). Saw that I no longer got links to 404s.	1bdbd7c497b98c238d4a868aba93042a777d5012
	Fix next/prev file attachments when Review UIs are unavailable. The next and previous file attachment pop-outs were broken if an attachment either did not have a Review UI, or had a Review UI which was not available. This change makes it so we check to ensure that the link will lead to a working page, and skip over any attachments that won't. Testing Done: Created a series of attachments where some file types just didn't have review UIs, and some had disabled review UIs (a PDF with a user who did not have access to power pack). Saw that I no longer got links to 404s.	37b4a5ebc0c7d86496c1a25b962c63b24afcdf83

Diff:

Revision 2 (+184 -114)

Show changes

	reviewboard/reviews/ui/base.py
	reviewboard/reviews/views/attachments.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (63ffb7f)