Improve typing in some review-request related code.
Review Request #14017 — Created July 9, 2024 and submitted
This change just has some typing and docs improvements in some code that
I've been touching to do the new admin-draft stuff.
Ran unit tests.
Summary | ID |
---|---|
4e20de2fdfde719807259d80ed3181e7da719fec |
Description | From | Last Updated |
---|---|---|
undefined name 'Tuple' Column: 10 Error code: F821 |
![]() |
|
undefined name 'List' Column: 29 Error code: F821 |
![]() |
|
trailing whitespace Column: 48 Error code: W291 |
![]() |
|
line too long (80 > 79 characters) Column: 80 Error code: E501 |
![]() |
|
These lines should be swapped. |
|
|
What is pending typed as? |
|
|
We shoudl probably use Sequence, since this doesn't need to be a mutable result. |
|
|
Might be a good time to begin making these arguments keyword-only. |
|
|
Missing Args. |
|
|
While here you could get rid of the "Return" language and "Returns" section, and use "Type:" instead. |
![]() |
|
Forgot to document **kwargs. |
![]() |
|
Missing a ** prefix to kwargs. |
![]() |
|
Missing Args. |
|
|
No colon here. |
|
- Commits:
-
Summary ID 648464efe389c79730b9b52d32e470f43dbe9a42 078f40b414cce33ce633687eee53ae26aac05407
Checks run (2 succeeded)
- Commits:
-
Summary ID 078f40b414cce33ce633687eee53ae26aac05407 e5d7b3aeccd4e27b11d37d7cf5f9ab1f81bdd4ca