Fix a crash when computing diff headers for filtered-out lines.

Review Request #14004 — Created July 1, 2024 and discarded

Information

Review Board
release-7.x

Reviewers

When attempting to generate diff headers on interdiffs, we can run into
a crash when processing this on a block of filtered-out lines. This is a
symptom of a larger issue with the interdiff filtering logic, which will
be dealt with separately, but can be easily worked around by checking
what we're comparing against before making assumptions about the data.

Verified the fix with an interdiff that exhibited the problem.

Summary ID
Fix a crash when computing diff headers for filtered-out lines.
When attempting to generate diff headers on interdiffs, we can run into a crash when processing this on a block of filtered-out lines. This is a symptom of a larger issue with the interdiff filtering logic, which will be dealt with separately, but can be easily worked around by checking what we're comparing against before making assumptions about the data.
4468f02c2847178eb1073dfbc3ef8cd512a42a68
chipx86
Review request changed
Status:
Discarded