Summary

Convert RB.ReviewGroup to TypeScript/spina.

Review Request #14002 — Created June 27, 2024 and submitted July 1, 2024, 9:51 a.m.

Owner

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Groups

People

Description

This change converts the group resource to TypeScript and spina.

Testing Done

Ran js-tests.

Commits

Summary	ID
Convert RB.ReviewGroup to TypeScript/spina. This change converts the group resource to TypeScript and spina. Testing Done: Ran js-tests.	8048114f42b2ec8622ffc4ec6e32712580aa2d6f

Issues

Description	From	Last Updated
These are missing docs.	chipx86	June 28, 2024, 9:47 p.m.
Missing docs.	chipx86	June 28, 2024, 9:47 p.m.
Can we move the interfaces all to the top of the file, so they're not scattered?	chipx86	June 28, 2024, 9:47 p.m.
Missing docs.	chipx86	June 28, 2024, 9:48 p.m.

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/common/resources/models/reviewGroupModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
These are missing docs.
```
reviewboard/static/rb/js/common/resources/models/reviewGroupModel.ts (Diff revision 1)
The issue has been dropped. Show all issues
```
Missing docs.
```

reviewboard/static/rb/js/common/resources/models/reviewGroupModel.ts (Diff revision 1)

The issue has been dropped. Show all issues

Can we move the interfaces all to the top of the file, so they're not scattered?

I think I'd prefer to keep the interfaces next to the classes that use them.

reviewboard/static/rb/js/common/resources/models/reviewGroupModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing docs.
```

Commits:

	Summary	ID
	Convert RB.ReviewGroup to TypeScript/spina. This change converts the group resource to TypeScript and spina. Testing Done: Ran js-tests.	9bbba666ddd713f6a580f3ceee878b500fafda9c
	Convert RB.ReviewGroup to TypeScript/spina. This change converts the group resource to TypeScript and spina. Testing Done: Ran js-tests.	8048114f42b2ec8622ffc4ec6e32712580aa2d6f

Diff:

Revision 2 (+314 -110)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	reviewboard/static/rb/js/common/resources/models/tests/index.ts
	reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js

flake8 passed.

JSHint passed.

Ship it!