Summary

Fix a crash when computing diff headers for filtered-out lines.

Review Request #14001 — Created June 26, 2024 and submitted July 1, 2024, 3:48 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When attempting to generate diff headers on interdiffs, we can run into
a crash when processing this on a block of filtered-out lines. This is a
symptom of a larger issue with the interdiff filtering logic, which will
be dealt with separately, but can be easily worked around by checking
what we're comparing against before making assumptions about the data.

Testing Done

Unit tests passed.

Verified that this fixed the crash occurring in an interdiff.

Commits

Summary	ID
Fix a crash when computing diff headers for filtered-out lines. When attempting to generate diff headers on interdiffs, we can run into a crash when processing this on a block of filtered-out lines. This is a symptom of a larger issue with the interdiff filtering logic, which will be dealt with separately, but can be easily worked around by checking what we're comparing against before making assumptions about the data.	40f5f349f17722206ad3c709ed8b98da3499d0a1

Summary

Fix a crash when computing diff headers for filtered-out lines.

When attempting to generate diff headers on interdiffs, we can run into a crash when processing this on a block of filtered-out lines. This is a symptom of a larger issue with the interdiff filtering logic, which will be dealt with separately, but can be easily worked around by checking what we're comparing against before making assumptions about the data.

40f5f349f17722206ad3c709ed8b98da3499d0a1

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (a19b5d9)