Summary

Convert RB.DefaultReviewer to TypeScript/spina.

Review Request #14000 — Created June 26, 2024 and submitted July 1, 2024, 9:51 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts the default reviewer resource to TypeScript/spina.

Testing Done

Ran js-tests.

Commits

Summary	ID
Convert RB.DefaultReviewer to TypeScript/spina. This change converts the default reviewer resource to TypeScript/spina. Testing Done: Ran js-tests.	db9dab9dda039ff3233be0c75d295db3057cc82f

Issues

Description	From	Last Updated
Missing docs.	chipx86	June 28, 2024, 9:35 p.m.
Missing docs.	chipx86	June 28, 2024, 9:36 p.m.

flake8 passed.

JSHint passed.

Description:

		This change converts the default reviewer resource to TypeScript/spina.
-
-		Testing Done:
-		Ran js-tests.

Testing Done:

Ran js-tests.

Commits:

	Summary	ID
	Convert RB.DefaultReviewer to TypeScript/spina. This change converts the default reviewer resource to TypeScript/spina. Testing Done: Ran js-tests.	20b7fdc7e17ae25420a327c39d5b6a4e9f9ff10a
	Convert RB.DefaultReviewer to TypeScript/spina. This change converts the default reviewer resource to TypeScript/spina. Testing Done: Ran js-tests.	eb741d50b946111fdfef8ec3c6c7323c76965bdb

Diff:

Revision 2 (+200 -108)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/defaultReviewerModel.ts
	reviewboard/static/rb/js/resources/models/tests/defaultReviewerModelTests.es6.js
	reviewboard/static/rb/js/common/resources/models/tests/index.ts
	reviewboard/static/rb/js/resources/models/defaultReviewerModel.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/common/resources/models/defaultReviewerModel.ts (Diff revision 2)

The issue has been resolved. Show all issues

Missing docs.

reviewboard/static/rb/js/common/resources/models/defaultReviewerModel.ts (Diff revision 2)

The issue has been dropped. Show all issues

Missing docs.

david June 28, 2024, 9:42 p.m.

We haven't been adding docs for these because it's just type info applied to the structures we get from the server, and would basically be copy/paste with the things directly above.

chipx86 June 29, 2024, 4:14 p.m.

Oh oops, I didn't notice this was serialization data.

Commits:

	Summary	ID
	Convert RB.DefaultReviewer to TypeScript/spina. This change converts the default reviewer resource to TypeScript/spina. Testing Done: Ran js-tests.	eb741d50b946111fdfef8ec3c6c7323c76965bdb
	Convert RB.DefaultReviewer to TypeScript/spina. This change converts the default reviewer resource to TypeScript/spina. Testing Done: Ran js-tests.	db9dab9dda039ff3233be0c75d295db3057cc82f

Diff:

Revision 3 (+206 -108)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/defaultReviewerModel.ts
	reviewboard/static/rb/js/resources/models/tests/defaultReviewerModelTests.es6.js
	reviewboard/static/rb/js/common/resources/models/tests/index.ts
	reviewboard/static/rb/js/resources/models/defaultReviewerModel.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (a7049d2)