Summary

Convert RB.Repository to TypeScript/spina.

Review Request #13995 — Created June 24, 2024 and submitted June 29, 2024, 12:03 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts the repository resource to TypeScript/spina.

Testing Done

Ran js-tests.

Commits

Summary	ID
Convert RB.Repository to TypeScript/spina. This change converts the repository resource to TypeScript/spina. Testing Done: Ran js-tests.	77127557f04c95f4fc074d7f7a4d9372128713d6

Issues

Description	From	Last Updated
Missing a one-line summary.	chipx86	June 24, 2024, 7:44 p.m.
Missing a one-line summary.	chipx86	June 24, 2024, 7:44 p.m.
Missing a one-line summary.	chipx86	June 24, 2024, 7:44 p.m.
You can use Record<string, string> here.	chipx86	June 24, 2024, 7:45 p.m.
Missing docs.	chipx86	June 24, 2024, 7:45 p.m.
While here, can you change this to "Return ..." ?	chipx86	June 24, 2024, 7:46 p.m.
This should reference RepositoryCommitsOptions.	chipx86	June 24, 2024, 7:49 p.m.
This is no longer needed.	chipx86	June 24, 2024, 7:49 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/models/repositoryModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Missing a one-line summary.

reviewboard/static/rb/js/common/resources/models/repositoryModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing a one-line summary.
```
reviewboard/static/rb/js/common/resources/models/repositoryModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing a one-line summary.
```
reviewboard/static/rb/js/common/resources/models/repositoryModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
You can use Record<string, string> here.
```
reviewboard/static/rb/js/common/resources/models/repositoryModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing docs.
```

reviewboard/static/rb/js/common/resources/models/repositoryModel.ts (Diff revision 1)

I don't love exposing this any more than we have to. We normally just pass in the options we care about as a type, though technically that's wrong... No blocker here, but we should find a better pattern.

reviewboard/static/rb/js/common/resources/models/repositoryModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
While here, can you change this to "Return ..." ?
```
reviewboard/static/rb/js/common/resources/models/repositoryModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This should reference RepositoryCommitsOptions.
```

reviewboard/static/rb/js/common/resources/models/repositoryModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

This is no longer needed.

Commits:

	Summary	ID
	Convert RB.Repository to TypeScript/spina. This change converts the repository resource to TypeScript/spina. Testing Done: Ran js-tests.	593d0f55b88eeab8bf11e07c95e78f295c91256f
	Convert RB.Repository to TypeScript/spina. This change converts the repository resource to TypeScript/spina. Testing Done: Ran js-tests.	5e05c42ca6c40eedb021ec9b498089166aa6302f

Diff:

Revision 2 (+370 -230)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/repositoryModel.ts
	reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts
	reviewboard/static/rb/js/resources/models/repositoryModel.es6.js
	reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Fix some version added notes.

Commits:

	Summary	ID
	Convert RB.Repository to TypeScript/spina. This change converts the repository resource to TypeScript/spina. Testing Done: Ran js-tests.	5e05c42ca6c40eedb021ec9b498089166aa6302f
	Convert RB.Repository to TypeScript/spina. This change converts the repository resource to TypeScript/spina. Testing Done: Ran js-tests.	77127557f04c95f4fc074d7f7a4d9372128713d6

Diff:

Revision 3 (+370 -230)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/repositoryModel.ts
	reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts
	reviewboard/static/rb/js/resources/models/repositoryModel.es6.js
	reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (3184d07)