Make the scale and moveState attributes of RegionCommentBlockView public.
Review Request #13986 — Created June 18, 2024 and submitted
When converting the
RegionCommentBlockView
class to TypeScript, we made all
of its attributes private. With the doc review work in Power Pack, we'll have
a child class ofRegionCommentBlockView
for document region comments. We
want to be able to access the scale and move state attribute from this
child class, but we can't do this since they've become private on RB7.This reverts back to how we had them before, renaming them from private
variables to their old_scale
and_moveState
names thus making them
public. This also means that for doc review region comments in Power Pack,
we don't have to deal with variable name compatibility, since the_scale
and_moveState
name is used across RB5, 6, and 7.0.1.One thing to note is that this means Power Pack 6 doc review region comments
will be broken on Review Board 7.0, they'll only be supported on 7.0.1+.
And, Power Pack 5.2.4's PDF review comments are only supported on 7.0.1+.
These comments are currently broken for 7.0. anyways.
Ran JS unit tests.
Tested created/moving/resizing/deleting PDF region comments.
Tested created/moving/resizing/deleting image region comments.
![maubin](https://media-reviews-reviewboard-org.s3.amazonaws.com/uploaded/avatars/m/ma/maubin__28892f51-5581-4db1-b65d-322d3b6117de.jpg?AWSAccessKeyId=AKIAQF2RGG6MLO3L2GME&Signature=HH3Ll%2FDXhESv6vyVe9RWHaf7fBM%3D&Expires=1725755045)
- Change Summary:
-
Added more description about supported versions.
- Description:
-
When converting the
RegionCommentBlockView
class to TypeScript, we made allof its attributes private. With the doc review work in Power Pack, we'll have a child class of RegionCommentBlockView
for document region comments. Wewant to be able to access the scale and move state attribute from this child class, but we can't do this since they've become private on RB7. This reverts back to how we had them before, renaming them from private
variables to their old _scale
and_moveState
names thus making thempublic. This also means that for doc review region comments in Power Pack, we don't have to deal with variable name compatibility, since the _scale
and _moveState
name is used across RB5, 6, and 7.0.1.One thing to note is that this means Power Pack 6 doc review region comments
~ will be broken on Review Board 7.0, they'll only be supported on 7.0.1+. ~ will be broken on Review Board 7.0, they'll only be supported on 7.0.1+. + And, Power Pack 5.2.4's PDF review comments are only supported on 7.0.1+. + These comments are currently broken for 7.0. anyways.