Summary

Override onInitialRender() instead of render() in AbstractCommentBlockView.

Review Request #13985 — Created June 18, 2024 and submitted June 19, 2024, 9:55 a.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Spina views should mostly override either onInitialRender() or onRender()
instead of render() because the latter manages important things like
model event registration and triggering render signals. This updates our
AbstractCommentBlockView to override the onInitialRender() method
instead of render(), which allows model event handlers to properly
register.

This fixes two regressions that we had:
1. When resizing/moving comments, the selection box wouldn't immediately
update to the new size.
3. When created a new comment on top of an existing published one, the
comment block view would only show the published one.

Testing Done


Ran unit tests.
Tested creating, deleting, moving and resizing region comments.
Tested adding a comment on top of an existing one.

Commits

Summary	ID
Override onInitialRender() instead of render() in AbstractCommentBlockView. Spina views should mostly override either `onInitialRender()` or `onRender()` instead of `render()` because the latter manages important things like model event registration and triggering render signals. This updates our `AbstractCommentBlockView` to override the `onInitialRender()` method instead of `render()`. That fixes a regression in our region comment resizing/moving, which was broken because the model events handlers for those weren't being registered previously.	b803943b5a802cdc4ae263cd7c57245a0b56b0e9

Summary

Override onInitialRender() instead of render() in AbstractCommentBlockView.

Spina views should mostly override either `onInitialRender()` or `onRender()` instead of `render()` because the latter manages important things like model event registration and triggering render signals. This updates our `AbstractCommentBlockView` to override the `onInitialRender()` method instead of `render()`. That fixes a regression in our region comment resizing/moving, which was broken because the model events handlers for those weren't being registered previously.

b803943b5a802cdc4ae263cd7c57245a0b56b0e9

Issues

Description	From	Last Updated
This can be protected now.	chipx86	June 19, 2024, 9:42 a.m.

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/reviews/views/abstractCommentBlockView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be protected now.
```

Commits:

	Summary	ID
	Override onInitialRender() instead of render() in AbstractCommentBlockView. Spina views should mostly override either `onInitialRender()` or `onRender()` instead of `render()` because the latter manages important things like model event registration and triggering render signals. This updates our `AbstractCommentBlockView` to override the `onInitialRender()` method instead of `render()`. That fixes a regression in our region comment resizing/moving, which was broken because the model events handlers for those weren't being registered previously. Ran unit tests. Tested creating, deleting, moving and resizing region comments.	1ef6c90692e75f0942638e314fa2ac22a2070580
	Override onInitialRender() instead of render() in AbstractCommentBlockView. Spina views should mostly override either `onInitialRender()` or `onRender()` instead of `render()` because the latter manages important things like model event registration and triggering render signals. This updates our `AbstractCommentBlockView` to override the `onInitialRender()` method instead of `render()`. That fixes a regression in our region comment resizing/moving, which was broken because the model events handlers for those weren't being registered previously.	b803943b5a802cdc4ae263cd7c57245a0b56b0e9

Diff:

Revision 2 (+2 -14)

Show changes

reviewboard/static/rb/js/reviews/views/abstractCommentBlockView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (7aa3561)