Fix background color of last selected page entry in configforms.

Review Request #13979 — Created June 17, 2024 and submitted

Information

Djblets
release-5.x

Reviewers

When the last page on a config form page is selected, the background of
the selected item had a border radius that was too large. This change
fixes it up to use a border radius to fit correctly (the border radius
of the outer container minus the width of the border itself).

Selected the last page in a configform set and saw that the TOC entry
looked correct.

Summary ID
Fix background color of last selected page entry in configforms.
When the last page on a config form page is selected, the background of the selected item had a border radius that was too large. This change fixes it up to use a border radius to fit correctly (the border radius of the outer container minus the width of the border itself). Testing Done: Selected the last page in a configform set and saw that the TOC entry looked correct.
1e891a4bfef648a469444a1259662a38efd9a1e4

Description From Last Updated

We have a var(--ink-u-border-radius-s-inner) (std is s -- we probably should have std-inner in INk). *-inner is meant for this …

chipx86chipx86
chipx86
  1. 
      
  2. Show all issues

    We have a var(--ink-u-border-radius-s-inner) (std is s -- we probably should have std-inner in INk).

    *-inner is meant for this use case, though it's possible the values are wrong. If so, we should adjust them or set those to use calc() instead, so we have a reliable variable to work with. Want to put that in Ink?

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (30db613)