Fix the confirmation button for deleting database entries.

Review Request #13978 — Created June 17, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

The button for deleting database entries (such as repositories) no
longer performed any actions in Review Board 7.0. This was due to the
button being defined as type="button", rather than the previous
type="submit".

We now mark this as a submit button instead, ensuring that pressing it
will perform the right action on the form.

Attempted to delete an option and found I could successfully confirm
the deletion.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Fix the confirmation button for deleting database entries.
The button for deleting database entries (such as repositories) no longer performed any actions in Review Board 7.0. This was due to the button being defined as `type="button"`, rather than the previous `type="submit"`. We now mark this as a submit button instead, ensuring that pressing it will perform the right action on the form.
f685504b715f99a51519c4df54e63ebe12ffd6e9 Christian Hammond
reviewboard/templates/admin/delete_confirmation.html
Loading...