Summary

Update integrations form and pop-up to work in dark mode.

Review Request #13976 — Created June 17, 2024 and submitted June 18, 2024, 4:29 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The integrations form and pop-up are nominally part of the admin UI,
which doesn't yet support dark mode, but that's not always the case.
This change makes it so we use an Ink button and icon for the "Add
Integration" button, and styles the pop-up to be legible in dark mode.

Testing Done

Used the integrations pop-up on a non-admin page with dark mode enabled.

Commits

Summary	ID
Update integrations form and pop-up to work in dark mode. The integrations form and pop-up are nominally part of the admin UI, which doesn't yet support dark mode, but that's not always the case. This change makes it so we use an Ink button and icon for the "Add Integration" button, and styles the pop-up to be legible in dark mode. Testing Done: Used the integrations pop-up on a non-admin page with dark mode enabled.	468d2804ad91e575dffbaa3c15249399a4871c2e

Summary

Update integrations form and pop-up to work in dark mode.

The integrations form and pop-up are nominally part of the admin UI, which doesn't yet support dark mode, but that's not always the case. This change makes it so we use an Ink button and icon for the "Add Integration" button, and styles the pop-up to be legible in dark mode. Testing Done: Used the integrations pop-up on a non-admin page with dark mode enabled.

468d2804ad91e575dffbaa3c15249399a4871c2e

Files

Issues

Description	From	Last Updated
Can I see a screenshot?	chipx86	June 17, 2024, 10:03 p.m.
This is missing ink-c-button__icon (first class).	chipx86	June 17, 2024, 10:03 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues
```
Can I see a screenshot?
```
djblets/integrations/templates/integrations/parts/integration_list.html (Diff revision 1)
The issue has been resolved. Show all issues
```
This is missing ink-c-button__icon (first class).
```

Added Files:

Commits:

	Summary	ID
	Update integrations form and pop-up to work in dark mode. The integrations form and pop-up are nominally part of the admin UI, which doesn't yet support dark mode, but that's not always the case. This change makes it so we use an Ink button and icon for the "Add Integration" button, and styles the pop-up to be legible in dark mode. Testing Done: Used the integrations pop-up on a non-admin page with dark mode enabled.	e73719a57d3969cf221925707f852a532da8d43a
	Update integrations form and pop-up to work in dark mode. The integrations form and pop-up are nominally part of the admin UI, which doesn't yet support dark mode, but that's not always the case. This change makes it so we use an Ink button and icon for the "Add Integration" button, and styles the pop-up to be legible in dark mode. Testing Done: Used the integrations pop-up on a non-admin page with dark mode enabled.	468d2804ad91e575dffbaa3c15249399a4871c2e

Diff:

Revision 2 (+22 -14)

Show changes

	djblets/integrations/templates/integrations/parts/integration_list.html
	djblets/static/djblets/css/integrations.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (f6c704d)