• 
      

    Make -is-* classes take priority over button type.

    Review Request #13974 — Created June 14, 2024 and submitted

    Information

    Ink
    master

    Reviewers

    The classes for ink buttons had combined rules for the class names and
    type attributes, but this meant that it was impossible to have a
    <button type="submit" class="-is-danger"> (since the submit rule came
    after the danger rule). This change splits those rules up so the classes
    will take priority over the type attribute.

    Used this on a page that had a submit button that needed to be marked as
    dangerous.

    Summary ID
    Make -is-* classes take priority over button type.
    The classes for ink buttons had combined rules for the class names and type attributes, but this meant that it was impossible to have a `<button type="submit" class="-is-danger">` (since the submit rule came after the danger rule). This change splits those rules up so the classes will take priority over the type attribute. Testing Done: Used this on a page that had a submit button that needed to be marked as dangerous.
    b0958d68ea8652e176398561e111342f39218045
    Description From Last Updated

    There's an extra * here.

    chipx86chipx86
    chipx86
    1. 
        
    2. Show all issues

      There's an extra * here.

    3. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (b685ea8)