Summary

Allow passing SCMTool IDs to the tool= parameter to the repositories API.

Review Request #13972 — Created June 11, 2024 and submitted June 12, 2024, 7:32 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The tool= parameter for the repositories API was implemented using
SCMTool names, but we've had various issues in the past where names were
fluid for one reason or another. This change makes it so we can pass in
the SCMTool ID for this parameter as well.

Additionally, we had a bug where passing as unknown name to this
parameter would cause a crash in the API because the tool returned from
the registry lookup was None. This has been fixed to just skip adding
that to the list.

Testing Done

Ran unit tests.

Commits

Summary	ID
Allow passing SCMTool IDs to the tool= parameter to the repositories API. The `tool=` parameter for the repositories API was implemented using SCMTool names, but we've had various issues in the past where names were fluid for one reason or another. This change makes it so we can pass in the SCMTool ID for this parameter as well. Additionally, we had a bug where passing as unknown name to this parameter would cause a crash in the API because the tool returned from the registry lookup was `None`. This has been fixed to just skip adding that to the list. Testing Done: Ran unit tests.	88fcc8e18bf0e577f1994de073bc7521ef0c2784

Summary

Allow passing SCMTool IDs to the tool= parameter to the repositories API.

The `tool=` parameter for the repositories API was implemented using SCMTool names, but we've had various issues in the past where names were fluid for one reason or another. This change makes it so we can pass in the SCMTool ID for this parameter as well. Additionally, we had a bug where passing as unknown name to this parameter would cause a crash in the API because the tool returned from the registry lookup was `None`. This has been fixed to just skip adding that to the list. Testing Done: Ran unit tests.

88fcc8e18bf0e577f1994de073bc7521ef0c2784

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (d303a62)