Summary

Add the registered SCMTools to the server capabilities blob.

Review Request #13971 — Created June 11, 2024 and submitted June 12, 2024, 7:33 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We currently don't have any way for clients to know what SCMTools are
available on the server. This change adds the IDs of the registered
SCMTools into the server capabilities.

Testing Done


Ran unit tests.
Fetched the server info resource and verified that the

  scmtools.supported_tools key was present in the capabilities. Checked

  that it contained the correct IDs depending on whether or not Power

  Pack was installed.

Commits

Summary	ID
Add the registered SCMTools to the server capabilities blob. We currently don't have any way for clients to know what SCMTools are available on the server. This change adds the IDs of the registered SCMTools into the server capabilities. Testing Done: - Ran unit tests. - Fetched the server info resource and verified that the scmtools.supported_tools key was present in the capabilities. Checked that it contained the correct IDs depending on whether or not Power Pack was installed.	94a439c268d241ea0a5fc2b0c16d9af1a605ed4c

Summary

Add the registered SCMTools to the server capabilities blob.

We currently don't have any way for clients to know what SCMTools are available on the server. This change adds the IDs of the registered SCMTools into the server capabilities. Testing Done: - Ran unit tests. - Fetched the server info resource and verified that the scmtools.supported_tools key was present in the capabilities. Checked that it contained the correct IDs depending on whether or not Power Pack was installed.

94a439c268d241ea0a5fc2b0c16d9af1a605ed4c

Issues

Description	From	Last Updated
Can we add unit tests for this?	chipx86	June 11, 2024, 8:48 p.m.
The inner [] shouldn't be needed. sorted() should do the right thing with a generator.	chipx86	June 11, 2024, 5:30 p.m.
missing whitespace around operator Column: 9 Error code: E225	reviewbot	June 11, 2024, 9:04 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues
```
Can we add unit tests for this?
```

reviewboard/webapi/server_info.py (Diff revision 1)

The issue has been resolved. Show all issues

The inner [] shouldn't be needed. sorted() should do the right thing with a generator.

Commits:

	Summary	ID
	Add the registered SCMTools to the server capabilities blob. We currently don't have any way for clients to know what SCMTools are available on the server. This change adds the IDs of the registered SCMTools into the server capabilities. Testing Done: - Ran unit tests. - Fetched the server info resource and verified that the scmtools.supported_tools key was present in the capabilities. Checked that it contained the correct IDs depending on whether or not Power Pack was installed.	d5abf79d01e1f4b3277b23fa0a0ab004de75b539
	Add the registered SCMTools to the server capabilities blob. We currently don't have any way for clients to know what SCMTools are available on the server. This change adds the IDs of the registered SCMTools into the server capabilities. Testing Done: - Ran unit tests. - Fetched the server info resource and verified that the scmtools.supported_tools key was present in the capabilities. Checked that it contained the correct IDs depending on whether or not Power Pack was installed.	9591d79c142ca676b79052c5fc991fd75556f869

Diff:

Revision 2 (+128 -4)

Show changes

	reviewboard/webapi/server_info.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_server_info.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_server_info.py (Diff revision 2)
The issue has been resolved. Show all issues
```
missing whitespace around operator

Column: 9
Error code: E225
```

Commits:

	Summary	ID
	Add the registered SCMTools to the server capabilities blob. We currently don't have any way for clients to know what SCMTools are available on the server. This change adds the IDs of the registered SCMTools into the server capabilities. Testing Done: - Ran unit tests. - Fetched the server info resource and verified that the scmtools.supported_tools key was present in the capabilities. Checked that it contained the correct IDs depending on whether or not Power Pack was installed.	9591d79c142ca676b79052c5fc991fd75556f869
	Add the registered SCMTools to the server capabilities blob. We currently don't have any way for clients to know what SCMTools are available on the server. This change adds the IDs of the registered SCMTools into the server capabilities. Testing Done: - Ran unit tests. - Fetched the server info resource and verified that the scmtools.supported_tools key was present in the capabilities. Checked that it contained the correct IDs depending on whether or not Power Pack was installed.	94a439c268d241ea0a5fc2b0c16d9af1a605ed4c

Diff:

Revision 3 (+128 -4)

Show changes

	reviewboard/webapi/server_info.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_server_info.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (ce70b52)