Summary

Modernize djblets/auth.

Review Request #13968 — Created June 10, 2024 and updated June 11, 2024, 10:39 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This change makes several modernizations for the auth app:

Add `from future import annotations' to everything.
Add type hints.
Fix up a few small type issues that were exposed by type hints.
Add in missing docstrings.

Testing Done

Ran unit tests.

Commits

Summary	ID
Modernize djblets/auth. This change makes several modernizations for the auth app: - Add `from __future__ import annotations' to everything. - Add type hints. - Fix up a few small type issues that were exposed by type hints. - Add in missing docstrings. Testing Done: Ran unit tests.	b9ea0aa76462b625872027672df0d8a5acf6aec8

Issues

Description	From	Last Updated
Can you add a Raises section in the docs while here.	maubin	June 11, 2024, 10:23 p.m.
Same here.	maubin	June 11, 2024, 10:24 p.m.

flake8 passed.

JSHint passed.

Description:

		This change makes several modernizations for the auth app:

		Add `from future import annotations' to everything.
		Add type hints.
		Fix up a few small type issues that were exposed by type hints.
		Add in missing docstrings.
-
-		Testing Done:
-		Ran unit tests.

Testing Done:

Ran unit tests.

Commits:

	Summary	ID
	Modernize djblets/auth. This change makes several modernizations for the auth app: - Add `from __future__ import annotations' to everything. - Add type hints. - Fix up a few small type issues that were exposed by type hints. - Add in missing docstrings. Testing Done: Ran unit tests.	c411630327f35ff9de62ec77ece6a72662c54cbe
	Modernize djblets/auth. This change makes several modernizations for the auth app: - Add `from __future__ import annotations' to everything. - Add type hints. - Fix up a few small type issues that were exposed by type hints. - Add in missing docstrings. Testing Done: Ran unit tests.	777c7e4e4566c1fea71e922922e28c4af4873253

Diff:

Revision 2 (+414 -160)

Show changes

	djblets/auth/apps.py
	djblets/auth/forms.py
	djblets/auth/ratelimit.py
	djblets/auth/signals.py
	djblets/auth/urls.py
	djblets/auth/util.py
	djblets/auth/views.py
	djblets/auth/tests/__init__.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/auth/ratelimit.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you add a Raises section in the docs while here.
```
djblets/auth/ratelimit.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Same here.
```

Commits:

	Summary	ID
	Modernize djblets/auth. This change makes several modernizations for the auth app: - Add `from __future__ import annotations' to everything. - Add type hints. - Fix up a few small type issues that were exposed by type hints. - Add in missing docstrings. Testing Done: Ran unit tests.	777c7e4e4566c1fea71e922922e28c4af4873253
	Modernize djblets/auth. This change makes several modernizations for the auth app: - Add `from __future__ import annotations' to everything. - Add type hints. - Fix up a few small type issues that were exposed by type hints. - Add in missing docstrings. Testing Done: Ran unit tests.	b9ea0aa76462b625872027672df0d8a5acf6aec8

Diff:

Revision 3 (+428 -158)

Show changes

	djblets/auth/apps.py
	djblets/auth/forms.py
	djblets/auth/ratelimit.py
	djblets/auth/signals.py
	djblets/auth/urls.py
	djblets/auth/util.py
	djblets/auth/views.py
	djblets/auth/tests/__init__.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

djblets/auth/ratelimit.py (Diff revision 2)

djblets/auth/ratelimit.py (Diff revision 2)