Summary

Move the patch-related classes into rbtools.diffs.patches.

Review Request #13966 — Created June 9, 2024 and updated June 10, 2024, 8:44 a.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

13965

Blocks

13969

Reviewers

Groups

rbtools

People

Description

During the cleanup of the SCM code in RBTools 4, we introduced
rbtools.clients.base.patch, which contained PatchAuthor and
PatchResult classes. In preparation for upcoming patch-related work,
these are moving once again to rbtools.diffs.patches.

The old module will continue to work, but is now marked deprecated. All
call sites have been migrated to the new module.

Testing Done

Unit tests passed, both with and without the import updates.

Commits

Summary	ID
Move the patch-related classes into rbtools.diffs.patches. During the cleanup of the SCM code in RBTools 4, we introduced `rbtools.clients.base.patch`, which contained `PatchAuthor` and `PatchResult` classes. In preparation for upcoming patch-related work, these are moving once again to `rbtools.diffs.patches`. The old module will continue to work, but is now marked deprecated. All call sites have been migrated to the new module.	9625402407de7b0e397705f77b04a86d91de8607

Summary

Move the patch-related classes into rbtools.diffs.patches.

During the cleanup of the SCM code in RBTools 4, we introduced `rbtools.clients.base.patch`, which contained `PatchAuthor` and `PatchResult` classes. In preparation for upcoming patch-related work, these are moving once again to `rbtools.diffs.patches`. The old module will continue to work, but is now marked deprecated. All call sites have been migrated to the new module.

9625402407de7b0e397705f77b04a86d91de8607

flake8 passed.

JSHint passed.

Change Summary:

Fixed the version number in which the classes were moved.

Commits:

	Summary	ID
	Move the patch-related classes into rbtools.diffs.patches. During the cleanup of the SCM code in RBTools 4, we introduced `rbtools.clients.base.patch`, which contained `PatchAuthor` and `PatchResult` classes. In preparation for upcoming patch-related work, these are moving once again to `rbtools.diffs.patches`. The old module will continue to work, but is now marked deprecated. All call sites have been migrated to the new module.	1add5c7a1e01258212e7ecbc52f6d9d650a9c81b
	Move the patch-related classes into rbtools.diffs.patches. During the cleanup of the SCM code in RBTools 4, we introduced `rbtools.clients.base.patch`, which contained `PatchAuthor` and `PatchResult` classes. In preparation for upcoming patch-related work, these are moving once again to `rbtools.diffs.patches`. The old module will continue to work, but is now marked deprecated. All call sites have been migrated to the new module.	9625402407de7b0e397705f77b04a86d91de8607

Diff:

Revision 2 (+420 -256)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/clients/svn.py
	rbtools/clients/base/patch.py
	rbtools/clients/base/scmclient.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```