Add types and require keyword-only args for PatchAuthor and PatchResult.

 






 

 


  Review Request #13965
  —
  Created June 8, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  RBTools
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 









 
 

  13966
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
In preparation for upcoming work, we've made a couple future-proofing

changes for PatchAuthor and PatchResult.


Both classes now take keyword-only arguments, rather than positional

arguments. Callers can continue to pass in positional arguments for now,

but this is deprecated and will be removed in RBTools 7. The RBTools

codebase already passes in all arguments as keywords.


They also now provide type hints for the attributes and the constructor

methods.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Add types and require keyword-only args for PatchAuthor and PatchResult.
     
In preparation for upcoming work, we've made a couple future-proofing
changes for `PatchAuthor` and `PatchResult`.

Both classes now take keyword-only arguments, rather than positional
arguments. Callers can continue to pass in positional arguments for now,
but this is deprecated and will be removed in RBTools 7. The RBTools
codebase already passes in all arguments as keywords.

They also now provide type hints for the attributes and the constructor
methods.

    

   
  		
  6dea05a5b84591eba1a3c0752d67d473959222c4
  Christian Hammond
 


 
  
 
 
  
   
    

     Add types and require keyword-only args for PatchAuthor and PatchResult.
     
In preparation for upcoming work, we've made a couple future-proofing
changes for `PatchAuthor` and `PatchResult`.

Both classes now take keyword-only arguments, rather than positional
arguments. Callers can continue to pass in positional arguments for now,
but this is deprecated and will be removed in RBTools 7. The RBTools
codebase already passes in all arguments as keywords.

They also now provide type hints for the attributes and the constructor
methods.

    

   
  		
  fb868b48a5ac71bfac20e6db4ecb5f4941b176cc
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/clients/base/patch.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...