Summary

Add types and require keyword-only args for PatchAuthor and PatchResult.

Review Request #13965 — Created June 8, 2024 and submitted July 13, 2024, 8:01 a.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Blocks

13966

Reviewers

Groups

rbtools

People

Description

In preparation for upcoming work, we've made a couple future-proofing
changes for PatchAuthor and PatchResult.

Both classes now take keyword-only arguments, rather than positional
arguments. Callers can continue to pass in positional arguments for now,
but this is deprecated and will be removed in RBTools 7. The RBTools
codebase already passes in all arguments as keywords.

They also now provide type hints for the attributes and the constructor
methods.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add types and require keyword-only args for PatchAuthor and PatchResult. In preparation for upcoming work, we've made a couple future-proofing changes for `PatchAuthor` and `PatchResult`. Both classes now take keyword-only arguments, rather than positional arguments. Callers can continue to pass in positional arguments for now, but this is deprecated and will be removed in RBTools 7. The RBTools codebase already passes in all arguments as keywords. They also now provide type hints for the attributes and the constructor methods.	fb868b48a5ac71bfac20e6db4ecb5f4941b176cc

Summary

Add types and require keyword-only args for PatchAuthor and PatchResult.

In preparation for upcoming work, we've made a couple future-proofing changes for `PatchAuthor` and `PatchResult`. Both classes now take keyword-only arguments, rather than positional arguments. Callers can continue to pass in positional arguments for now, but this is deprecated and will be removed in RBTools 7. The RBTools codebase already passes in all arguments as keywords. They also now provide type hints for the attributes and the constructor methods.

fb868b48a5ac71bfac20e6db4ecb5f4941b176cc

flake8 passed.

JSHint passed.

Change Summary:

Fixed the patch_content type to be bytes instead of the (incorrectly-documented) str.

Commits:

	Summary	ID
	Add types and require keyword-only args for PatchAuthor and PatchResult. In preparation for upcoming work, we've made a couple future-proofing changes for `PatchAuthor` and `PatchResult`. Both classes now take keyword-only arguments, rather than positional arguments. Callers can continue to pass in positional arguments for now, but this is deprecated and will be removed in RBTools 7. The RBTools codebase already passes in all arguments as keywords. They also now provide type hints for the attributes and the constructor methods.	6dea05a5b84591eba1a3c0752d67d473959222c4
	Add types and require keyword-only args for PatchAuthor and PatchResult. In preparation for upcoming work, we've made a couple future-proofing changes for `PatchAuthor` and `PatchResult`. Both classes now take keyword-only arguments, rather than positional arguments. Callers can continue to pass in positional arguments for now, but this is deprecated and will be removed in RBTools 7. The RBTools codebase already passes in all arguments as keywords. They also now provide type hints for the attributes and the constructor methods.	fb868b48a5ac71bfac20e6db4ecb5f4941b176cc

Diff:

Revision 2 (+130 -30)

Show changes

rbtools/clients/base/patch.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (65e5bc4)