• 
      

    Remove unnecessary and broken prototypeAttrs override for TableItemView.

    Review Request #13960 — Created June 7, 2024 and submitted

    Information

    Djblets
    release-5.x

    Reviewers

    TableItemView was including a prototypeAttrs override listing the
    template member, but this is already included in the parent class one,
    and we automerge those. Unfortunately, having this override seems to
    have triggered a different bug in spina's automerge where we were losing
    the other items. This was causing us to not have action handlers for the
    extension list, breaking the "Enable" and "Disable" actions.

    Saw that I was able to enable and disable extensions.

    Summary ID
    Remove unnecessary and broken prototypeAttrs override for TableItemView.
    TableItemView was including a prototypeAttrs override listing the `template` member, but this is already included in the parent class one, and we automerge those. Unfortunately, having this override seems to have triggered a different bug in spina's automerge where we were losing the other items. This was causing us to not have action handlers for the extension list, breaking the "Enable" and "Disable" actions. Testing Done: Saw that I was able to enable and disable extensions.
    bd25647ef701c17bd3d52fcde3d45f152f628913
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-5.x (5fdd578)