Summary

Bump version and modernize version utility code.

Review Request #13956 — Created June 6, 2024 and submitted June 16, 2024, 8:38 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change bumps Review Board to 8.x on the master branch, updates the

djblets dependency to match, and modernizes all our package versioning

utilities.

Testing Done

Ran setup.py develop.

Commits

Summary	ID
Bump version and modernize version utility code. This change bumps Review Board to 8.x on the master branch, updates the djblets dependency to match, and modernizes all our package versioning utilities. Testing Done: Ran setup.py develop.	d56520206e35d54b9431695f5ba4abbf49fb48ec

Issues

Description	From	Last Updated
Since this is a core package information module, let's go for the widest compatibility and use Type[...] and not type[...].	chipx86	June 16, 2024, 8:17 p.m.
We should reserve _ for gettext. We can just assign to VERSION[:-1].	chipx86	June 16, 2024, 8:19 p.m.
Old code, but I've been changing other modules to use VERSION[-1] here since that's always going to be the release …	chipx86	June 16, 2024, 8:19 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/__init__.py (Diff revision 1)

The issue has been dropped. Show all issues

Since this is a core package information module, let's go for the widest compatibility and use Type[...] and not type[...].

david June 16, 2024, 8:13 p.m.

Because this is an annotation and we're using from __future__ import annotations they both end up as strings. There's no compatibility difference.

chipx86 June 16, 2024, 8:14 p.m.
```
True, that's fair.
```

reviewboard/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We should reserve _ for gettext. We can just assign to VERSION[:-1].
```

reviewboard/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

Old code, but I've been changing other modules to use VERSION[-1] here since that's always going to be the release flag.

Commits:

	Summary	ID
	Bump version and modernize version utility code. This change bumps Review Board to 8.x on the master branch, updates the djblets dependency to match, and modernizes all our package versioning utilities. Testing Done: Ran setup.py develop.	60ad9c0f1a85686db9bb91936a42aac7cffd15a5
	Bump version and modernize version utility code. This change bumps Review Board to 8.x on the master branch, updates the djblets dependency to match, and modernizes all our package versioning utilities. Testing Done: Ran setup.py develop.	d56520206e35d54b9431695f5ba4abbf49fb48ec

Diff:

Revision 2 (+126 -82)

Show changes

	reviewboard/__init__.py
	reviewboard/dependencies.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (df6fcf8)