Fix archive and mute menu items.

 






 

 


  Review Request #13938
  —
  Created June 4, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The recent fix for the click handlers to menu items broke the items in

the archive menu, because those weren't properly converted to be

MenuItemAction subclasses that implemented activate(). This change

does that, removing the custom event handling they were doing.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Verified that I could [un]archive and [un]mute from the menu items.
    • 

  • Verified that clicking on the archive menu header still toggled the
    
  archive state.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix archive and mute menu items.
     
The recent fix for the click handlers to menu items broke the items in
the archive menu, because those weren't properly converted to be
`MenuItemAction` subclasses that implemented `activate()`. This change
does that, removing the custom event handling they were doing.

Testing Done:
- Ran js-tests.
- Verified that I could [un]archive and [un]mute from the menu items.
- Verified that clicking on the archive menu header still toggled the
  archive state.

    

   
  		
  6e66dd011211b21df5344051b046a92e2550212b
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...