Summary

Fix archive and mute menu items.

Review Request #13938 — Created June 4, 2024 and submitted June 4, 2024, 10:28 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The recent fix for the click handlers to menu items broke the items in
the archive menu, because those weren't properly converted to be
MenuItemAction subclasses that implemented activate(). This change
does that, removing the custom event handling they were doing.

Testing Done


Ran js-tests.
Verified that I could [un]archive and [un]mute from the menu items.
Verified that clicking on the archive menu header still toggled the

  archive state.

Commits

Summary	ID
Fix archive and mute menu items. The recent fix for the click handlers to menu items broke the items in the archive menu, because those weren't properly converted to be `MenuItemAction` subclasses that implemented `activate()`. This change does that, removing the custom event handling they were doing. Testing Done: - Ran js-tests. - Verified that I could [un]archive and [un]mute from the menu items. - Verified that clicking on the archive menu header still toggled the archive state.	6e66dd011211b21df5344051b046a92e2550212b

Summary

Fix archive and mute menu items.

The recent fix for the click handlers to menu items broke the items in the archive menu, because those weren't properly converted to be `MenuItemAction` subclasses that implemented `activate()`. This change does that, removing the custom event handling they were doing. Testing Done: - Ran js-tests. - Verified that I could [un]archive and [un]mute from the menu items. - Verified that clicking on the archive menu header still toggled the archive state.

6e66dd011211b21df5344051b046a92e2550212b

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (0ffe21f)