Summary

Fix scrolling in the text editor in the comment dialog.

Review Request #13929 — Created June 4, 2024 and submitted June 4, 2024, 9:42 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Testing Done


Verified that the scroll wheel did not do anything when moused over

  parts of the comment dialog other than the text editor.
Verified that the scroll wheel did not do anything when moused over an

  empty text field, in both markdown and plain text modes.
Verified that the scroll wheel did not do anything when moused over

  text that did not overflow the text editor in markdown mode.
Verified that the scroll wheel scrolled the text editor when working

  with long comments in both markdown and plan text modes.
Ran js-tests.

Commits

Summary	ID
Fix scrolling in the text editor in the comment dialog. The fix to prevent accidentally scrolling away from the comment dialog broke scrolling within the text editor. This change adds some smarts so we figure out if we're trying to scroll in the text editor and the text editor is capable of scrolling, we'll allow it, and if not, we'll continue to swallow the event. Testing Done: - Verified that the scroll wheel did not do anything when moused over parts of the comment dialog other than the text editor. - Verified that the scroll wheel did not do anything when moused over an empty text field, in both markdown and plain text modes. - Verified that the scroll wheel did not do anything when moused over text that did not overflow the text editor in markdown mode. - Verified that the scroll wheel scrolled the text editor when working with long comments in both markdown and plan text modes. - Ran js-tests.	89842d83e392503d389cb166b61e49b262337355

Summary

Fix scrolling in the text editor in the comment dialog.

The fix to prevent accidentally scrolling away from the comment dialog broke scrolling within the text editor. This change adds some smarts so we figure out if we're trying to scroll in the text editor and the text editor is capable of scrolling, we'll allow it, and if not, we'll continue to swallow the event. Testing Done: - Verified that the scroll wheel did not do anything when moused over parts of the comment dialog other than the text editor. - Verified that the scroll wheel did not do anything when moused over an empty text field, in both markdown and plain text modes. - Verified that the scroll wheel did not do anything when moused over text that did not overflow the text editor in markdown mode. - Verified that the scroll wheel scrolled the text editor when working with long comments in both markdown and plan text modes. - Ran js-tests.

89842d83e392503d389cb166b61e49b262337355

Issues

Description	From	Last Updated
Modern TypeScript is moving to ... as HTMLElement. The <Type>var is considered legacy.	chipx86	June 4, 2024, 3:14 p.m.
To be safest, we should use: target.classList.contains('CodeMirror-scroll')	chipx86	June 4, 2024, 3:14 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Modern TypeScript is moving to ... as HTMLElement. The <Type>var is considered legacy.
```
reviewboard/static/rb/js/reviews/views/commentDialogView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
To be safest, we should use: target.classList.contains('CodeMirror-scroll')
```

Commits:

	Summary	ID
	Fix scrolling in the text editor in the comment dialog. The fix to prevent accidentally scrolling away from the comment dialog broke scrolling within the text editor. This change adds some smarts so we figure out if we're trying to scroll in the text editor and the text editor is capable of scrolling, we'll allow it, and if not, we'll continue to swallow the event. Testing Done: - Verified that the scroll wheel did not do anything when moused over parts of the comment dialog other than the text editor. - Verified that the scroll wheel did not do anything when moused over an empty text field, in both markdown and plain text modes. - Verified that the scroll wheel did not do anything when moused over text that did not overflow the text editor in markdown mode. - Verified that the scroll wheel scrolled the text editor when working with long comments in both markdown and plan text modes. - Ran js-tests.	e015fbb756e5cf30b563e9d3098d786738f34a18
	Fix scrolling in the text editor in the comment dialog. The fix to prevent accidentally scrolling away from the comment dialog broke scrolling within the text editor. This change adds some smarts so we figure out if we're trying to scroll in the text editor and the text editor is capable of scrolling, we'll allow it, and if not, we'll continue to swallow the event. Testing Done: - Verified that the scroll wheel did not do anything when moused over parts of the comment dialog other than the text editor. - Verified that the scroll wheel did not do anything when moused over an empty text field, in both markdown and plain text modes. - Verified that the scroll wheel did not do anything when moused over text that did not overflow the text editor in markdown mode. - Verified that the scroll wheel scrolled the text editor when working with long comments in both markdown and plan text modes. - Ran js-tests.	89842d83e392503d389cb166b61e49b262337355

Diff:

Revision 2 (+54 -2)

Show changes

reviewboard/static/rb/js/reviews/views/commentDialogView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (6ac9d68)