Fix text alignment issues between TH and TD cells in datagrids.

 






 

 


  Review Request #13921
  —
  Created June 3, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Djblets
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
When using a datagrid that consists of both TH and TD cells in a row,

content alignment would begin to fail. This is due to some inherited

browser styles for vertical alignment on TH, and different padding

definitions between TH and TD.


We now set the alignment and padding on both of these at the same time,

ensuring they line up.

 








  


 
 

  
Tested all the typical datagrids in Review Board, plus the admin UI

datagrids, ensuring that alignment was always correct.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix text alignment issues between TH and TD cells in datagrids.
     
When using a datagrid that consists of both TH and TD cells in a row,
content alignment would begin to fail. This is due to some inherited
browser styles for vertical alignment on TH, and different padding
definitions between TH and TD.

We now set the alignment and padding on both of these at the same time,
ensuring they line up.

    

   
  		
  5d6525def4ff6a78c7a253817ce754cd5b7aa05e
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/static/djblets/css/datagrid.less
     
    

   
  

 










     

    

   

  

  

   
   Loading...