Summary

Fix text alignment issues between TH and TD cells in datagrids.

Review Request #13921 — Created June 3, 2024 and submitted June 3, 2024, 8:58 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

When using a datagrid that consists of both TH and TD cells in a row,
content alignment would begin to fail. This is due to some inherited
browser styles for vertical alignment on TH, and different padding
definitions between TH and TD.

We now set the alignment and padding on both of these at the same time,
ensuring they line up.

Testing Done

Tested all the typical datagrids in Review Board, plus the admin UI
datagrids, ensuring that alignment was always correct.

Commits

Summary	ID
Fix text alignment issues between TH and TD cells in datagrids. When using a datagrid that consists of both TH and TD cells in a row, content alignment would begin to fail. This is due to some inherited browser styles for vertical alignment on TH, and different padding definitions between TH and TD. We now set the alignment and padding on both of these at the same time, ensuring they line up.	5d6525def4ff6a78c7a253817ce754cd5b7aa05e

Files

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (4358c09)