Add dark mode support and a better hit area for auto-complete menus.

Review Request #13913 — Created May 31, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

The auto-complete menus were pretty much invisible on dark mode, with a
default white text on a hard-coded white background.

We now use the Ink Menu color palette for the menus, giving us a
consistent appearance with other menus.

The standard menu item padding is also used now, giving us a larger hit
area for the auto-complete items and better visual separation. This
allows us to get rid of the mobile-specific styling as well.

The search results menu has also been fixed to be positioned correctly
below the main navigation pane. Positioning changes had broken the
display, causing it to overlap incorrecly.

Tested the search results and review request auto-complete menus in
dark and light mode, and on desktop and mobile.

Summary ID
Add dark mode support and a better hit area for auto-complete menus.
The auto-complete menus were pretty much invisible on dark mode, with a default white text on a hard-coded white background. We now use the Ink Menu color palette for the menus, giving us a consistent appearance with other menus. The standard menu item padding is also used now, giving us a larger hit area for the auto-complete items and better visual separation. This allows us to get rid of the mobile-specific styling as well. The search results menu has also been fixed to be positioned correctly below the main navigation pane. Positioning changes had broken the display, causing it to overlap incorrecly.
fe4fb26b5f2382a3dce26456429e879523dd0692

david
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.x (7384dca)