flake8
passed.
JSHint
passed.
Review Request #13908 — Created May 29, 2024 and submitted
We have a variety of ways that we link to specific places in the diff
viewer, and one of the most common and useful is clicking on the link
from a comment to jump straight to the comment in context. This was
broken a while back.The fundamental cause here is that the
selectAnchor()
method is
checking whether the comment flag's element is shown, but
TextBasedCommentBlock
defers its own show operation in order to let
layout settle. We therefore were always bailing early.This change makes two fixes:
#startAtAnchorName
thing.selectAnchor()
and verify that we