Consolidate review request UI CSS imports to an index.less.
Review Request #13904 — Created May 29, 2024 and submitted
The files in
css/ui/review-request/
andcss/ui/reviews/
were being
imported into the bundle individually, which gave us two paths to deal
with any time we wanted to add a new file.We now provide
index.less
files in both directories, which contain the
imports for that directory, giving the bundle one place exactly to
import from.There are plenty of remaining problems with our CSS directory layout,
but those are for another time.
Successfully built the CSS.
Summary | ID |
---|---|
a493e2e7974c163c6a1bcfe2cdcf8d66e9ff3496 |
- Change Summary:
-
Added an
index.less
forreviews
, since that also needs one and the file in there got removed from the bundle unintentionally. - Description:
-
~ The files in
css/ui/review-request/
were being imported into the~ bundle individually, which gave us two paths to deal with any time we ~ wanted to add a new file. ~ The files in
css/ui/review-request/
andcss/ui/reviews/
were being~ imported into the bundle individually, which gave us two paths to deal ~ with any time we wanted to add a new file. ~ We now provide a
css/ui/review-request/index.less
, which contains the~ We now provide
index.less
files in both directories, which contain theimports for that directory, giving the bundle one place exactly to import from. There are plenty of remaining problems with our CSS directory layout,
but those are for another time. - Commits:
-
Summary ID 1455447e2af1ad19c14e9a3a5da86ef42a0d05ce a493e2e7974c163c6a1bcfe2cdcf8d66e9ff3496