Summary

Consolidate review request UI CSS imports to an index.less.

Review Request #13904 — Created May 29, 2024 and submitted May 30, 2024, 9:02 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The files in css/ui/review-request/ and css/ui/reviews/ were being

imported into the bundle individually, which gave us two paths to deal

with any time we wanted to add a new file.
We now provide index.less files in both directories, which contain the

imports for that directory, giving the bundle one place exactly to

import from.
There are plenty of remaining problems with our CSS directory layout,

but those are for another time.

Testing Done

Successfully built the CSS.

Commits

Summary	ID
Consolidate review request UI CSS imports to an index.less. The files in `css/ui/review-request/` and `css/ui/reviews/` were being imported into the bundle individually, which gave us two paths to deal with any time we wanted to add a new file. We now provide `index.less` files in both directories, which contain the imports for that directory, giving the bundle one place exactly to import from. There are plenty of remaining problems with our CSS directory layout, but those are for another time.	a493e2e7974c163c6a1bcfe2cdcf8d66e9ff3496

Summary

Consolidate review request UI CSS imports to an index.less.

The files in `css/ui/review-request/` and `css/ui/reviews/` were being imported into the bundle individually, which gave us two paths to deal with any time we wanted to add a new file. We now provide `index.less` files in both directories, which contain the imports for that directory, giving the bundle one place exactly to import from. There are plenty of remaining problems with our CSS directory layout, but those are for another time.

a493e2e7974c163c6a1bcfe2cdcf8d66e9ff3496

flake8 passed.

JSHint passed.

Change Summary:

Added an index.less for reviews, since that also needs one and the file in there got removed from the bundle unintentionally.

Description:

~		The files in `css/ui/review-request/` were being imported into the
~		bundle individually, which gave us two paths to deal with any time we
~		wanted to add a new file.
	~	The files in `css/ui/review-request/` and `css/ui/reviews/` were being
	~	imported into the bundle individually, which gave us two paths to deal
	~	with any time we wanted to add a new file.

~		We now provide a `css/ui/review-request/index.less`, which contains the
	~	We now provide `index.less` files in both directories, which contain the
		imports for that directory, giving the bundle one place exactly to
		import from.

		There are plenty of remaining problems with our CSS directory layout,
		but those are for another time.

Commits:

	Summary	ID
	Consolidate review request UI CSS imports to an index.less. The files in `css/ui/review-request/` were being imported into the bundle individually, which gave us two paths to deal with any time we wanted to add a new file. We now provide a `css/ui/review-request/index.less`, which contains the imports for that directory, giving the bundle one place exactly to import from. There are plenty of remaining problems with our CSS directory layout, but those are for another time.	1455447e2af1ad19c14e9a3a5da86ef42a0d05ce
	Consolidate review request UI CSS imports to an index.less. The files in `css/ui/review-request/` and `css/ui/reviews/` were being imported into the bundle individually, which gave us two paths to deal with any time we wanted to add a new file. We now provide `index.less` files in both directories, which contain the imports for that directory, giving the bundle one place exactly to import from. There are plenty of remaining problems with our CSS directory layout, but those are for another time.	a493e2e7974c163c6a1bcfe2cdcf8d66e9ff3496

Diff:

Revision 2 (+22 -16)

Show changes

	reviewboard/static/rb/css/bundles/reviews.less
	reviewboard/static/rb/css/ui/review-request/index.less
	reviewboard/static/rb/css/ui/reviews/index.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (b11f900)