Fix colors and styling for commit list and field changes.

Review Request #13902 — Created May 28, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

When working on the diff theme support, the commit lists ended up with
a broken background color in light mode for the "-" and "+" operators.
This happened because a variable these depended on became an alpha
overlay color, rather than using a base color for insert/delete.

All the diff op colors have been updated to use base colors, ensuring
consistency there in both light and dark modes. The commits list has
also been updated to use a more correct font size in the process, so the
summary and message don't appear substantially larger than the
surrounding elements.

The standard file fields have been updated to match the same colors as
well, along with the same icons shown in the commit list and the same
padding. This helps bring consistency between the two elements. Right
now, these definitions are duplicated. Work needs to be done to build
CSS components for this part of the UI.

Tested several fields and the commit list in both light and dark modes.

Summary ID
Fix colors and styling for commit list and field changes.
When working on the diff theme support, the commit lists ended up with a broken background color in light mode for the "-" and "+" operators. This happened because a variable these depended on became an alpha overlay color, rather than using a base color for insert/delete. All the diff op colors have been updated to use base colors, ensuring consistency there in both light and dark modes. The commits list has also been updated to use a more correct font size in the process, so the summary and message don't appear substantially larger than the surrounding elements. The standard file fields have been updated to match the same colors as well, along with the same icons shown in the commit list and the same padding. This helps bring consistency between the two elements. Right now, these definitions are duplicated. Work needs to be done to build CSS components for this part of the UI.
cf178de2ee316c70f27a11789f2fa020c2cb6428

maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.x (a95850f)