Convert RB.Admin.PageView to TypeScript/spina.

 






 

 


  Review Request #13893
  —
  Created May 22, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change converts the admin PageView class to TypeScript. This

particular class is actually empty, but converting it will help

alleviate an unrelated issue where some ad blockers would see a file

called "pageView.js" and block it.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Used the admin UI.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Convert RB.Admin.PageView to TypeScript/spina.
     
This change converts the admin PageView class to TypeScript. This
particular class is actually empty, but converting it will help
alleviate an unrelated issue where some ad blockers would see a file
called "pageView.js" and block it.

Testing Done:
- Ran js-tests.
- Used the admin UI.

    

   
  		
  95be4b752a23a06c8fffd27c1d335618ea52e178
  David Trowbridge
 


 
  
 
 
  
   
    

     Convert RB.Admin.PageView to TypeScript/spina.
     
This change converts the admin PageView class to TypeScript. This
particular class is actually empty, but converting it will help
alleviate an unrelated issue where some ad blockers would see a file
called "pageView.js" and block it.

Testing Done:
- Ran js-tests.
- Used the admin UI.

    

   
  		
  104a96be254b41254c84fc1148cd4d2c968975a8
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/admin/index.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/admin/views/baseAdminPageView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/admin/views/pageView.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...