Summary

Convert RB.Admin.PageView to TypeScript/spina.

Review Request #13893 — Created May 22, 2024 and submitted May 28, 2024, 10:12 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts the admin PageView class to TypeScript. This

particular class is actually empty, but converting it will help

alleviate an unrelated issue where some ad blockers would see a file

called "pageView.js" and block it.

Testing Done


Ran js-tests.
Used the admin UI.

Commits

Summary	ID
Convert RB.Admin.PageView to TypeScript/spina. This change converts the admin PageView class to TypeScript. This particular class is actually empty, but converting it will help alleviate an unrelated issue where some ad blockers would see a file called "pageView.js" and block it. Testing Done: - Ran js-tests. - Used the admin UI.	104a96be254b41254c84fc1148cd4d2c968975a8

Issues

Description	From	Last Updated
Can this be written to import just once? Failing that, can we keep the imports above the exports?	chipx86	May 22, 2024, 11:21 p.m.
Maybe we should rename this to BaseAdminPageView now? And then index.ts can export that directly, and we can keep the …	chipx86	May 22, 2024, 9:58 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/admin/index.ts (Diff revision 1)

The issue has been dropped. Show all issues

Can this be written to import just once?
Failing that, can we keep the imports above the exports?

david May 22, 2024, 10:01 p.m.

There doesn't seem to be a syntax for that (export AdminPageView doesn't work).

I think I'd prefer to have it grouped this way. The imports are purely related to the legacy namespace, and once we decide we can nuke that, we just delete the bottom half of the file.

chipx86 May 22, 2024, 11:22 p.m.

Okay. If we have to do anything more convoluted to export that, then it's not worth it. Dropping the issue.

reviewboard/static/rb/js/admin/views/pageView.ts (Diff revision 1)

The issue has been resolved. Show all issues

Maybe we should rename this to BaseAdminPageView now? And then index.ts can export that directly, and we can keep the legacy name in Admin.

Commits:

	Summary	ID
	Convert RB.Admin.PageView to TypeScript/spina. This change converts the admin PageView class to TypeScript. This particular class is actually empty, but converting it will help alleviate an unrelated issue where some ad blockers would see a file called "pageView.js" and block it. Testing Done: - Ran js-tests. - Used the admin UI.	95be4b752a23a06c8fffd27c1d335618ea52e178
	Convert RB.Admin.PageView to TypeScript/spina. This change converts the admin PageView class to TypeScript. This particular class is actually empty, but converting it will help alleviate an unrelated issue where some ad blockers would see a file called "pageView.js" and block it. Testing Done: - Ran js-tests. - Used the admin UI.	104a96be254b41254c84fc1148cd4d2c968975a8

Diff:

Revision 2 (+68 -16)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/admin/index.ts
	reviewboard/static/rb/js/admin/views/baseAdminPageView.ts
	reviewboard/static/rb/js/admin/views/pageView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (646aa5c)