• 
      

    Add dark mode and modern tabs to the text and Markdown review UI.

    Review Request #13890 — Created May 22, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    The text review UI has been updated to support dark mode styling. The
    text content already supported dark mode, but the custom tabs and the
    overridden styles for the filename header did not.

    We now use rb-c-tabs for the tabs, helping that fit in with much of
    the UI. We also use the default diff viewer header styling that we
    inherit for the filename information.

    Tabs had to be updated to ensure we correctly override the color and
    text-decoration for the label, in case <a> is used (which is the
    case here).

    With this, we now have full dark mode support for text and Markdown
    review.

    Tested in light and dark modes with single revisions, diffs, plain
    text, and Markdown files.

    Summary ID
    Add dark mode and modern tabs to the text and Markdown review UI.
    The text review UI has been updated to support dark mode styling. The text content already supported dark mode, but the custom tabs and the overridden styles for the filename header did not. We now use `rb-c-tabs` for the tabs, helping that fit in with much of the UI. We also use the default diff viewer header styling that we inherit for the filename information. Tabs had to be updated to ensure we correctly override the `color` and `text-decoration` for the label, in case `<a>` is used (which is the case here). With this, we now have full dark mode support for text and Markdown review.
    ccaa52a4d0235e033ac680cbe09b255d490a9371

    maubin
    1. Looks great!

    2. reviewboard/static/rb/css/ui/tabs.less (Diff revision 1)
       
       

      Just curious, what does this single & do here?

    3. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (cafe4e1)