Add dark mode for the activity indicator, and improve the appearance.

Review Request #13889 — Created May 22, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

The activity indicator was inheriting the default white color in dark
mode, which clashed with the hard-coded yellow on the indicator. The
look was also very dated in general.

We now use our Ink light color palette for the background, and the
on-light colors for the text and links, giving a consistent appearance
between light and dark modes. This particularly stands out well on dark
mode.

The appearance has also changed to be more of a pill shape with
consistent, flexible spacing, slightly offset from the top. This
replaces the docked fixed-size rectangle we had from the olden days.

Tested loading/saving indicators and the server error display on both
light and dark modes.

Summary ID
Add dark mode for the activity indicator, and improve the appearance.
The activity indicator was inheriting the default white color in dark mode, which clashed with the hard-coded yellow on the indicator. The look was also very dated in general. We now use our Ink light color palette for the background, and the on-light colors for the text and links, giving a consistent appearance between light and dark modes. This particularly stands out well on dark mode. The appearance has also changed to be more of a pill shape with consistent, flexible spacing, slightly offset from the top. This replaces the docked fixed-size rectangle we had from the olden days.
c278973beefb3f77b4f610b1c8387ad947ffcee5

maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.x (831910e)