Summary

Add a MenuLabel component, for label/menubar-like drop-down menu handles.

Review Request #13884 — Created May 21, 2024 and submitted May 22, 2024, 12:06 a.m.

Information

Owner

chipx86

Repository

Ink

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

MenuLabel provides a simple label with an optional icon and a
drop-down handle. Hovering over it will display a drop-down menu.

This works very much like MenuButton, but without all the button state
options or visual appearance of a button. It's intended for simple
drop-down controls in a toolbar and for usage in menubars.

Testing Done

Unit tests passed.

Tested in Storybook, and in usage within Review Board.

Commits

Summary	ID
Add a MenuLabel component, for label/menubar-like drop-down menu handles. `MenuLabel` provides a simple label with an optional icon and a drop-down handle. Hovering over it will display a drop-down menu. This works very much like `MenuButton`, but without all the button state options or visual appearance of a button. It's intended for simple drop-down controls in a toolbar and for usage in menubars.	ef92a64a765d0da78d4deddb65f818d5d4391f02

Summary

Add a MenuLabel component, for label/menubar-like drop-down menu handles.

`MenuLabel` provides a simple label with an optional icon and a drop-down handle. Hovering over it will display a drop-down menu. This works very much like `MenuButton`, but without all the button state options or visual appearance of a button. It's intended for simple drop-down controls in a toolbar and for usage in menubars.

ef92a64a765d0da78d4deddb65f818d5d4391f02

Files

Issues

Description	From	Last Updated
Typo: "rulees"	maubin	May 22, 2024, 12:04 a.m.
Need to list the -opens-up modifier in the class string.	maubin	May 22, 2024, 12:05 a.m.

flake8 passed.

JSHint passed.

Change Summary:

Switch to using <span> as the element type instead of <a>, to avoid over-aggressive styles leaking into the component.

Commits:

	Summary	ID
	Add a MenuLabel component, for label/menubar-like drop-down menu handles. `MenuLabel` provides a simple label with an optional icon and a drop-down handle. Hovering over it will display a drop-down menu. This works very much like `MenuButton`, but without all the button state options or visual appearance of a button. It's intended for simple drop-down controls in a toolbar and for usage in menubars.	75f7e62f8210e944676fe513c7566684686d93ff
	Add a MenuLabel component, for label/menubar-like drop-down menu handles. `MenuLabel` provides a simple label with an optional icon and a drop-down handle. Hovering over it will display a drop-down menu. This works very much like `MenuButton`, but without all the button state options or visual appearance of a button. It's intended for simple drop-down controls in a toolbar and for usage in menubars.	ef92a64a765d0da78d4deddb65f818d5d4391f02

Diff:

Revision 2 (+2698)

Show changes

	src/ink/js/components/views/index.ts
	src/ink/js/components/views/menuLabelView.ts
	src/ink/js/components/views/tests/menuLabelViewTests.ts
	src/ink/less/components/index.less
	src/ink/less/components/menu-label.component.less
	src/ink/less/components/schemas/index.less
	src/ink/less/components/schemas/menu-label.schema.less
	src/ink/less/themes/default/components/index.less
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

src/ink/less/components/menu-label.component.less (Diff revision 2)
The issue has been resolved. Show all issues
```
Typo: "rulees"
```
src/ink/less/components/schemas/menu-label.schema.less (Diff revision 2)
The issue has been resolved. Show all issues
```
Need to list the -opens-up modifier in the class string.
```

Ship it!

Once you fix the issues Michelle raised, I'm happy with this.

Status:: Completed
Change Summary:: Pushed to master (8334ea2)