• 
  
    
 
    
 
    

    



    
    
    
    
     
    






    
 
    


 
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Don't open menus on MenuButtons when disabled.
    
 
    

    



 
    
 
    

  Review Request #13883
  —
  Created May 21, 2024 and submitted  — Latest diff uploaded 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  chipx86
 
    

    





    
 
 
    
  Ink
 
    

    





    
 
 
    
  master
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  beanbag-misc
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    BaseMenuHandleView now allows subclasses to specify whether a menu is
    
allowed to displayed, depending on the state of the component. This is
    
done via a canOpenMenu() function, which subclasses can override.
    

    MenuButtonView overrides this to disable menus when the component is
    
disabled, ensuring it's fully non-interactive.
    
 
    

    





  

    
 
 
    
  
    Unit tests passed.
    

    Tested this in Storybook.
    
 
    

    




 
    

    





    
 
    









 




 
    

    




   
    
    
    
    
    
    
    
    

    
    
      
    Commits
    
      
    
        
      
    
    
    

    
    

      
    Files