Summary

Don't open menus on MenuButtons when disabled.

Review Request #13883 — Created May 21, 2024 and submitted May 22, 2024, 12:06 a.m.

Information

Owner

chipx86

Repository

Ink

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

BaseMenuHandleView now allows subclasses to specify whether a menu is
allowed to displayed, depending on the state of the component. This is
done via a canOpenMenu() function, which subclasses can override.

MenuButtonView overrides this to disable menus when the component is
disabled, ensuring it's fully non-interactive.

Testing Done

Unit tests passed.

Tested this in Storybook.

Commits

Summary	ID
Don't open menus on MenuButtons when disabled. `BaseMenuHandleView` now allows subclasses to specify whether a menu is allowed to displayed, depending on the state of the component. This is done via a `canOpenMenu()` function, which subclasses can override. `MenuButtonView` overrides this to disable menus when the component is disabled, ensuring it's fully non-interactive.	8579c075c5057595844b7388f750949d9a7aad71

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (311eda8)