Fix the display of diff errors in dark mode.

 






 

 


  Review Request #13879
  —
  Created May 20, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Diff errors had a white-on-yellow background on dark mode, due to using

a hard-coded background color and the default text color.


We now use the text-on-light color, and the warning alert color for the

background. This matches the warning alert style we use elsewhere, which

is designed to be quite noticeable on light and dark modes.

 








  


 
 

  
Tested diff errors on both dark and light modes.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix the display of diff errors in dark mode.
     
Diff errors had a white-on-yellow background on dark mode, due to using
a hard-coded background color and the default text color.

We now use the text-on-light color, and the warning alert color for the
background. This matches the warning alert style we use elsewhere, which
is designed to be quite noticeable on light and dark modes.

    

   
  		
  d22d56033b67c147d2d8d9251f10165b3ab08c42
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/css/pages/diffviewer.less
     
    

   
  

 










     

    

   

  

  

   
   Loading...