Summary

Fix the display of diff errors in dark mode.

Review Request #13879 — Created May 20, 2024 and submitted May 20, 2024, 10 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Diff errors had a white-on-yellow background on dark mode, due to using
a hard-coded background color and the default text color.

We now use the text-on-light color, and the warning alert color for the
background. This matches the warning alert style we use elsewhere, which
is designed to be quite noticeable on light and dark modes.

Testing Done

Tested diff errors on both dark and light modes.

Commits

Summary	ID
Fix the display of diff errors in dark mode. Diff errors had a white-on-yellow background on dark mode, due to using a hard-coded background color and the default text color. We now use the text-on-light color, and the warning alert color for the background. This matches the warning alert style we use elsewhere, which is designed to be quite noticeable on light and dark modes.	d22d56033b67c147d2d8d9251f10165b3ab08c42

Files

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (df18f00)