• 
      

    Fix the CodeMirror cursor display in dark mode.

    Review Request #13876 — Created May 20, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    We were inheriting the default style for the CodeMirror cursor in some
    uses, which resulted in a black-on-black cursor. We were overriding this
    correctly in rich text fields, but not elsewhere.

    This change moves the fixed styling into the common CodeMirror
    definition, fixing that. While I was at it, I also removed the
    now-redundant selection styling, utilizing the common definition that
    was placed there before.

    Tested the CodeMirror usage in both review request fields and in the
    API Token Policy editor, checking both the cursor and the selections to
    make sure they were visible in light and dark modes.

    Summary ID
    Fix the CodeMirror cursor display in dark mode.
    We were inheriting the default style for the CodeMirror cursor in some uses, which resulted in a black-on-black cursor. We were overriding this correctly in rich text fields, but not elsewhere. This change moves the fixed styling into the common CodeMirror definition, fixing that. While I was at it, I also removed the now-redundant selection styling, utilizing the common definition that was placed there before.
    fba6916e21753468baba34f235041ba6d4a94e10

    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (e767a7d)