Summary

Add a base class for CI configuration forms.

Review Request #13866 — Created May 19, 2024 and submitted May 20, 2024, 9:28 p.m.

Information

Owner

chipx86

Repository

rbintegrations

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbintegrations

People

Description

We had a couple of form fields that were common to all CI configuration

forms, and have another one coming shortly. To avoid continuing to

duplicate fields, and to ease the development of new CI integrations,

this change introduces a new BaseCIIntegrationConfigForm class that

can house these fields.
All CI integrations now use this form as a base. The Travis-CI

integration does need to override the conditions field in order to

limit to GitHub repositories, but inherits everything else.

Testing Done

Unit tests pass.

Tested each CI configuration form.

Commits

Summary	ID
Add a base class for CI configuration forms. We had a couple of form fields that were common to all CI configuration forms, and have another one coming shortly. To avoid continuing to duplicate fields, and to ease the development of new CI integrations, this change introduces a new `BaseCIIntegrationConfigForm` class that can house these fields. All CI integrations now use this form as a base. The Travis-CI integration does need to override the `conditions` field in order to limit to GitHub repositories, but inherits everything else.	a35b7a5ad6f273a60c90ca923acb17beca7a6ec7

Summary

Add a base class for CI configuration forms.

We had a couple of form fields that were common to all CI configuration forms, and have another one coming shortly. To avoid continuing to duplicate fields, and to ease the development of new CI integrations, this change introduces a new `BaseCIIntegrationConfigForm` class that can house these fields. All CI integrations now use this form as a base. The Travis-CI integration does need to override the `conditions` field in order to limit to GitHub repositories, but inherits everything else.

a35b7a5ad6f273a60c90ca923acb17beca7a6ec7

Issues

Description	From	Last Updated
'djblets.forms.widgets.AmountSelectorWidget' imported but unused Column: 1 Error code: F401	reviewbot	May 19, 2024, 11:48 p.m.

flake8 failed.

JSHint passed.

flake8

rbintegrations/baseci/forms.py (Diff revision 1)

The issue has been resolved. Show all issues

'djblets.forms.widgets.AmountSelectorWidget' imported but unused

Column: 1
Error code: F401

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Add a base class for CI configuration forms. We had a couple of form fields that were common to all CI configuration forms, and have another one coming shortly. To avoid continuing to duplicate fields, and to ease the development of new CI integrations, this change introduces a new `BaseCIIntegrationConfigForm` class that can house these fields. All CI integrations now use this form as a base. The Travis-CI integration does need to override the `conditions` field in order to limit to GitHub repositories, but inherits everything else.	162af9e6b3b7f3d146545aa6322d01ec6c6d2fb4
	Add a base class for CI configuration forms. We had a couple of form fields that were common to all CI configuration forms, and have another one coming shortly. To avoid continuing to duplicate fields, and to ease the development of new CI integrations, this change introduces a new `BaseCIIntegrationConfigForm` class that can house these fields. All CI integrations now use this form as a base. The Travis-CI integration does need to override the `conditions` field in order to limit to GitHub repositories, but inherits everything else.	a35b7a5ad6f273a60c90ca923acb17beca7a6ec7

Diff:

Revision 2 (+102 -80)

Show changes

	rbintegrations/baseci/forms.py
	rbintegrations/circleci/forms.py
	rbintegrations/jenkinsci/forms.py
	rbintegrations/travisci/forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.x (53e4ce8)