• 
      

    Fix limiting Travis CI configurations to GitHub repositories.

    Review Request #13865 — Created May 19, 2024 and submitted

    Information

    rbintegrations
    release-4.x

    Reviewers

    Originally, the Travis CI configuration had an overridden base queryset
    used to limit results to GitHub repositories, in order to help
    administrators select only compatible repositories.

    This has since broken, as get_queryset() was overridden and no longer
    utilized the base queryset, falling back to showing all repositories
    again.

    This change fixes that by overriding get_queryset() and filtering the
    parent method's result, once again enabling the filtering.

    Unit tests are added to ensure this doesn't regress.

    Unit tests pass.

    Verified that only GitHub repositories appeared when viewing the form.

    Summary ID
    Fix limiting Travis CI configurations to GitHub repositories.
    Originally, the Travis CI configuration had an overridden base queryset used to limit results to GitHub repositories, in order to help administrators select only compatible repositories. This has since broken, as `get_queryset()` was overridden and no longer utilized the base queryset, falling back to showing all repositories again. This change fixes that by overriding `get_queryset()` and filtering the parent method's result, once again enabling the filtering. Unit tests are added to ensure this doesn't regress.
    b2f8091eed955b8d54e95cc1492c9d19a474eadb
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.x (9fead6f)