Summary

Bump jQuery and jQuery-UI versions for Djblets.

Review Request #13859 — Created May 14, 2024 and submitted May 18, 2024, 3:16 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Djblets doesn't package jQuery and jQuery-UI specifically, but it's

listed as a dependency because we do have code that uses these

libraries. This change bumps the version of those.

Testing Done

Ran npm install.

Commits

Summary	ID
Bump jQuery and jQuery-UI versions for Djblets. Djblets doesn't package jQuery and jQuery-UI specifically, but it's listed as a dependency because we do have code that uses these libraries. This change bumps the version of those. Testing Done: - Ran npm install.	a7c2574135848a99fb42fa14c6367767c0714987

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Thanks for taking this on.

I want to make sure we've tested every use of jQuery-UI in both Djblets and Review Board. The testing only shows an install test, but this is a big upgrade.

chipx86 May 15, 2024, 3:05 p.m.

An important part of testing here is also going to be making sure that the comment dialog can still be dragged by touch.

david May 15, 2024, 3:47 p.m.

So this particular change is for Djblets, which doesn't actually use these things from node_modules, they're just pulled in during development. Testing of actual functionality is in the RB side of this change. I'll flesh that one out a bit, including touch drag.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (d87d9f7)