Use automergeAttrs for BaseResource and subclasses.

 






 

 


  Review Request #13853
  —
  Created May 13, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change makes use of automergeAttrs for our resource classes.

Spina itself specifies this for defaults, which means we don't have to

manually call _.defaults() for all of these. This additionally makes

use of it for attrToJsonMap, deserializers, and serializers.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Verified that all objects were properly automerged.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Use automergeAttrs for BaseResource and subclasses.
     
This change makes use of `automergeAttrs` for our resource classes.
Spina itself specifies this for `defaults`, which means we don't have to
manually call `_.defaults()` for all of these. This additionally makes
use of it for `attrToJsonMap`, `deserializers`, and `serializers`.

Testing Done:
- Ran js-tests.
- Verified that all objects were properly automerged.

    

   
  		
  059f82cdd65a0b9b53b67180eba170148a991bd7
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/baseCommentModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/draftReviewModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/fileAttachmentModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/reviewModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/reviewReplyModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...