Summary

Flatten the Djblets.Config.* namespace.

Review Request #13849 — Created May 10, 2024 and submitted May 18, 2024, 3:16 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

TypeScript gets unhappy if you're mixing what it considers to be a

"namespace" with ES modules, and can end up discarding a lot of type

checking as a result. Their recommendation is that everything these days

should be modules.
Before we switched to modules, we were starting to try to namespace our

code more thoroughly, and therefore everything inside the Djblets

configForms bundle was namespaced into Djblets.Config.*.
This change makes it so we export two names for each top-level item,

Djblets.Config.* and Djblets.Config*. This allows us to import the

ConfigForms* names from djblets/configForms without getting any warnings.

Testing Done


Ran js-tests.
Verified that the compiled configForms index.js file only had one copy

  of the definitions for the classes but was exporting them under both

  names.

Commits

Summary	ID
Flatten the Djblets.Config.* namespace. TypeScript gets unhappy if you're mixing what it considers to be a "namespace" with ES modules, and can end up discarding a lot of type checking as a result. Their recommendation is that everything these days should be modules. Before we switched to modules, we were starting to try to namespace our code more thoroughly, and therefore everything inside the Djblets configForms bundle was namespaced into `Djblets.Config.`. This change makes it so we export two names for each top-level item, `Djblets.Config.` and `Djblets.Config`. This allows us to import the `Config` names from `djblets/configForms` without getting any warnings. Testing Done: - Ran js-tests. - Verified that the compiled configForms index.js file only had one copy of the definitions for the classes but was exporting them under both names.	3c7425c5ef7d2924195d410d7ffe8cad82bccbf5

Summary

Flatten the Djblets.Config.* namespace.

TypeScript gets unhappy if you're mixing what it considers to be a "namespace" with ES modules, and can end up discarding a lot of type checking as a result. Their recommendation is that everything these days should be modules. Before we switched to modules, we were starting to try to namespace our code more thoroughly, and therefore everything inside the Djblets configForms bundle was namespaced into `Djblets.Config.*`. This change makes it so we export two names for each top-level item, `Djblets.Config.*` and `Djblets.Config*`. This allows us to import the `Config*` names from `djblets/configForms` without getting any warnings. Testing Done: - Ran js-tests. - Verified that the compiled configForms index.js file only had one copy of the definitions for the classes but was exporting them under both names.

3c7425c5ef7d2924195d410d7ffe8cad82bccbf5

Issues

Description	From	Last Updated
This should be in the expanded, one-type-per-line form.	chipx86	May 18, 2024, 3:15 p.m.

flake8 passed.

JSHint passed.

I know this is a major change to this, but I actually feel like ConfigForms is a more appropriate prefix than Config. Granted, the latter maps to what we already had, but wasn't really explicit enough either. Config sounds too much like configuration for Djblets.

chipx86 May 15, 2024, 3:05 p.m.

An important part of testing here is also going to be making sure that the comment dialog can still be dragged by touch.

chipx86 May 15, 2024, 3:05 p.m.
```
Oops, wrong review request.
```

Change Summary:

Switch to ConfigForms* for names.

Description:

		TypeScript gets unhappy if you're mixing what it considers to be a
		"namespace" with ES modules, and can end up discarding a lot of type
		checking as a result. Their recommendation is that everything these days
		should be modules.

		Before we switched to modules, we were starting to try to namespace our
		code more thoroughly, and therefore everything inside the Djblets
		configForms bundle was namespaced into `Djblets.Config.*`.

		This change makes it so we export two names for each top-level item,
		`Djblets.Config.` and `Djblets.Config`. This allows us to import the
~		`Config*` names from `djblets/configForms` without getting any warnings.
	~	`ConfigForms*` names from `djblets/configForms` without getting any warnings.

Commits:

	Summary	ID
	Flatten the Djblets.Config.* namespace. TypeScript gets unhappy if you're mixing what it considers to be a "namespace" with ES modules, and can end up discarding a lot of type checking as a result. Their recommendation is that everything these days should be modules. Before we switched to modules, we were starting to try to namespace our code more thoroughly, and therefore everything inside the Djblets configForms bundle was namespaced into `Djblets.Config.`. This change makes it so we export two names for each top-level item, `Djblets.Config.` and `Djblets.Config`. This allows us to import the `Config` names from `djblets/configForms` without getting any warnings. Testing Done: - Ran js-tests. - Verified that the compiled configForms index.js file only had one copy of the definitions for the classes but was exporting them under both names.	5f1a96e33fa1a97588fec883fcbd01cc462970cb
	Flatten the Djblets.Config.* namespace. TypeScript gets unhappy if you're mixing what it considers to be a "namespace" with ES modules, and can end up discarding a lot of type checking as a result. Their recommendation is that everything these days should be modules. Before we switched to modules, we were starting to try to namespace our code more thoroughly, and therefore everything inside the Djblets configForms bundle was namespaced into `Djblets.Config.`. This change makes it so we export two names for each top-level item, `Djblets.Config.` and `Djblets.Config`. This allows us to import the `Config` names from `djblets/configForms` without getting any warnings. Testing Done: - Ran js-tests. - Verified that the compiled configForms index.js file only had one copy of the definitions for the classes but was exporting them under both names.	3c7425c5ef7d2924195d410d7ffe8cad82bccbf5

Diff:

Revision 2 (+254 -170)

Show changes

	djblets/static/djblets/js/configForms/index.ts
	djblets/static/djblets/js/configForms/collections/listItemsCollection.ts
	djblets/static/djblets/js/configForms/models/tests/listItemModelTests.ts
	djblets/static/djblets/js/configForms/views/listView.ts
	djblets/static/djblets/js/configForms/views/tests/listItemViewTests.ts
	djblets/static/djblets/js/configForms/views/tests/listViewTests.ts
	djblets/static/djblets/js/configForms/views/tests/tableItemViewTests.ts
	djblets/static/djblets/js/configForms/views/tests/tableViewTests.ts
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

djblets/static/djblets/js/configForms/collections/listItemsCollection.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
This should be in the expanded, one-type-per-line form.
```

Status:: Completed
Change Summary:: Pushed to release-5.x (a6659e7)