Fix "Update Diff" to do the right thing on review requests with history.

Review Request #13846 — Created May 8, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

When a review request has commit history, it needs to always be updated
via RBTools. Attempting to use "Update Diff" to upload a diff file will
break in a confusing and useless way.

This change makes it so we show an informative error instead of letting
the user choose a diff file and then showing them an unknown error.

This also gets rid of an obsolete implementation for this that hadn't
been removed from ReviewRequestEditorView.

Clicked "Update Diff" on a review request with commit history and saw
the new error dialog. Did it on a review request without commit history
and saw the upload dialog as before.

Changes between revision 3 and 4

orig
1
2
3
4

Commits

Summary ID Author
Fix "Update Diff" to do the right thing on review requests with history.
When a review request has commit history, it needs to always be updated via RBTools. Attempting to use "Update Diff" to upload a diff file will break in a confusing and useless way. This change makes it so we show an informative error instead of letting the user choose a diff file and then showing them an unknown error. This also gets rid of an obsolete implementation for this that hadn't been removed from ReviewRequestEditorView. Testing Done: Clicked "Update Diff" on a review request with commit history and saw the new error dialog. Did it on a review request without commit history and saw the upload dialog as before.
acb98eb84723d2648d569501499bfa9a43cec4e3 David Trowbridge
Fix "Update Diff" to do the right thing on review requests with history.
When a review request has commit history, it needs to always be updated via RBTools. Attempting to use "Update Diff" to upload a diff file will break in a confusing and useless way. This change makes it so we show an informative error instead of letting the user choose a diff file and then showing them an unknown error. This also gets rid of an obsolete implementation for this that hadn't been removed from ReviewRequestEditorView. Testing Done: Clicked "Update Diff" on a review request with commit history and saw the new error dialog. Did it on a review request without commit history and saw the upload dialog as before.
be8e8f5d88985ee7074f62a0f42643a374719473 David Trowbridge
docs/manual/users/review-requests/uploading-diffs.rst
Loading...