Fix "Update Diff" to do the right thing on review requests with history.

Review Request #13846 — Created May 8, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

When a review request has commit history, it needs to always be updated
via RBTools. Attempting to use "Update Diff" to upload a diff file will
break in a confusing and useless way.

This change makes it so we show an informative error instead of letting
the user choose a diff file and then showing them an unknown error.

This also gets rid of an obsolete implementation for this that hadn't
been removed from ReviewRequestEditorView.

Clicked "Update Diff" on a review request with commit history and saw
the new error dialog. Did it on a review request without commit history
and saw the upload dialog as before.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.

orig
1
2
3
4

Commits

First Last Summary ID Author
Fix "Update Diff" to do the right thing on review requests with history.
When a review request has commit history, it needs to always be updated via RBTools. Attempting to use "Update Diff" to upload a diff file will break in a confusing and useless way. This change makes it so we show an informative error instead of letting the user choose a diff file and then showing them an unknown error. This also gets rid of an obsolete implementation for this that hadn't been removed from ReviewRequestEditorView. Testing Done: Clicked "Update Diff" on a review request with commit history and saw the new error dialog. Did it on a review request without commit history and saw the upload dialog as before.
c5b732062a883b76f389de5447a49a310cfd37af David Trowbridge
reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
Loading...